SFR 2238/run gha on local #537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ayan1229
requested review from
samanthaandrews,
jackiequach,
kristojorg,
Toxiapo and
oliviawongnyc
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
jackiequach
reviewed
Oct 15, 2024
.github/workflows/Playwright.yml
Outdated
|
|
||
| - name: Wait for the application to start | ||
| run: | | ||
| sleep 30 # Ensure the app has enough time to start up |
There was a problem hiding this comment.
nit: feel free to remove the comment. I think the name of the task is descriptive
jackiequach
approved these changes
Oct 17, 2024
| @@ -2,7 +2,7 @@ | |||
| "default": { | |||
| "import": ["playwright/tests/**/*.ts", "playwright/support/**/*.ts"], | |||
| "worldParameters": { | |||
| "appUrl": "https://drb-qa.nypl.org", | |||
| "appUrl": "http://localhost:3000", | |||
There was a problem hiding this comment.
If login is tested you may want to use local.nypl.org
kylevillegas93
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Ticket
This PR does the following: